Skip to content

Fixed bug #8755 : Replicator could produce log segments with duplicated segment numbers. #8756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

Fixed bug #8755 : Replicator could produce log segments with duplicated segment numbers. #8756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/jrd/replication/Manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "../common/isc_proto.h"
#include "../common/isc_s_proto.h"
#include "../jrd/jrd.h"
#include "../jrd/cch_proto.h"

#include "Manager.h"
#include "Protocol.h"
Expand Down Expand Up @@ -112,10 +113,24 @@ Manager::Manager(const string& dbId,

dbb->ensureGuid(tdbb);
const Guid& guid = dbb->dbb_guid;
m_sequence = dbb->dbb_repl_sequence;

if (config->journalDirectory.hasData())
{
// At this point it is unknown if change log shared memory exists or not.
// To avoid race condition with concurrent changing of current replication
// sequence, take and hold shared lock on header page while creating
// ChangeLog instance.

WIN window(HEADER_PAGE_NUMBER);
CCH_FETCH(tdbb, &window, LCK_read, pag_header);

Cleanup releaseHeader([&] {
CCH_RELEASE(tdbb, &window);
});

// Call below will fetch header page with LCK_read lock, it is allowed and OK.
m_sequence = dbb->getReplSequence(tdbb);

m_changeLog = FB_NEW_POOL(getPool())
ChangeLog(getPool(), dbId, guid, m_sequence, config);
}
Expand Down
Loading