Skip to content

Conversation

@FM1337
Copy link
Collaborator

@FM1337 FM1337 commented Jun 10, 2023

Info

There's a few reasons for this PR:

  1. PythonNet was a pain to work with and basically meant that features that IDEs have to make your life easier would basically not work.
  2. For some reason starting with the Net 7 builds, things would just not work correctly at all (auto legalization was getting stuck with no clue on the reason why)
    • This would have taken weeks to months to figure out given my last experience with it
  3. Since dotnet is cross platform it just makes more sense to run it directly rather than use a middleman like Python to do hackish magic to run c# functions

Additionally this marks me moving away from running it inside a Docker container (there is still a docker image you can build and run without issue) to experiment with how I host it. I may return to using Docker in the future for hosting it, but for now I just want to try something different.

@FM1337 FM1337 marked this pull request as ready for review June 10, 2023 23:26
@FM1337 FM1337 self-assigned this Jun 10, 2023
@FM1337 FM1337 mentioned this pull request Jun 10, 2023
@FM1337
Copy link
Collaborator Author

FM1337 commented Jun 11, 2023

Waited for reviews, got no response from the team, need to get moving on migrating this code to a new server, so I'm going to merge it anyway.

If there are bugs found I'll address them later.

@FM1337 FM1337 merged commit c687f8e into master Jun 11, 2023
@FM1337 FM1337 deleted the back-to-sharp branch June 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants