feat!: Restore v3 OfflineHandler interface
#162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
changed the title
OfflineHandler interfaceOfflineHandler interface
gagantrivedi
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we restore the
OfflineHandlerinterface from v3.x, with a number of improvements:BaseOfflineHandlerabstract base class andOfflineHandlerprotocol are available to ensure compatibility in runtime and typecheck time.EnvironmentModelis now aTypedDictrather than a Pydantic model; it still can be instantiated in a compatible manner, and used for validation, e.g., against an Pydantic type adapter.LocalFileHandlerperforms validation by running an evaluation context mapper.Review difficulty: 2/5