feat(analytics-flags): Add support for feature flag analytics #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
commented
Sep 16, 2021
flagsmith/analytics.py
Outdated
| class AnalyticsProc(UserDict): | ||
| """ | ||
| AnalyticsProc is you to track how often individual Flags are evaluated within the Flagsmith SDK | ||
| AnalyticsProc is usedd to track how often individual Flags are evaluated within the Flagsmith SDK |
dabeeeenster
changed the title
matthewelwell
requested changes
Sep 23, 2021
matthewelwell
requested changes
Sep 28, 2021
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Can we add some tests to this too please?
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
@gagantrivedi one to discuss I think.
matthewelwell
approved these changes
Oct 5, 2021
Contributor
|
@gagantrivedi I've added a couple of minor changes and approved it. Could you sort out the conflicts and merge it? Then we need to get a release out to PyPi. |
Contributor
|
@gagantrivedi I can help with the release to pypi |
gagantrivedi
force-pushed
the
feat/analytics-flags
branch
from
a1cc0c3 to
dcbe95e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: https://docs.flagsmith.com/advanced-use/flag-analytics