Skip to content

feat(ID-4358): showing success instead of fail message when build completed with errors #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024
Merged

feat(ID-4358): showing success instead of fail message when build completed with errors #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion interface.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,17 @@ <h4><small>App submission status</small></h4>
<div class="app-build-name">There was an error building your app</div>
\{{/if}}
</td>
\{{/if}} \{{#if cancelled}}
\{{/if}}
\{{#if gracefullyFailed }}
<td class="app-build-progress success">
<div class="app-build-progress-holder"><i class="fa fa-check-circle"></i> Completed</div>
</td>
<td class="app-build-details">
\{{#if updatedAt}}<span><span class="icon"><i class="fa fa-flag-checkered"></i> Finished on:</span> \{{updatedAt}}</span>\{{/if}}
<div class="app-build-name">\{{{message}}}</div>
</td>
\{{/if}}
\{{#if cancelled}}
<td class="app-build-progress warning">
<div class="app-build-progress-holder"><i class="fa fa-ban"></i> Canceled</div>
</td>
Expand Down
9 changes: 8 additions & 1 deletion js/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2149,14 +2149,21 @@ function checkSubmissionStatus(origin, iosSubmissions) {
build.submittedAt = ((submission.status === 'queued' || submission.status === 'submitted') && submission.submittedAt)
? moment(submission.submittedAt).format('MMM Do YYYY, h:mm:ss a')
: '';
build[submission.status] = true;

build.fileUrl = appBuild ? removeAuthTokenFromFileUrl(appBuild.url) : '';
build.versionNumber = _.get(submission, ['data', submissionTypePrefixes[submissionType] + 'versionNumber']);

if (submission.result.message) {
build.message = submission.result.message;

const gracefullyFailedMessage = "The app has been uploaded to the App Store Connect but could not be submitted for review. Please log in on https://appstoreconnect.apple.com/ to finish up the process and submit the app for review.";
if (submission.result.message === gracefullyFailedMessage) {
submission.status = 'gracefullyFailed';
}
}

build[submission.status] = true;

if (submission.result.errorCode < 0) {
build.message = 'There was an error processing your submission. To learn more, go to <a target="_blank" href="https://help.fliplet.com/common-apple-issues/">help.fliplet.com/common-apple-issues</a>.';
}
Expand Down