Skip to content

Add changes to test on staging #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Add changes to test on staging #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b59fdb
Add changes to test on staging
armine-fliplet Dec 27, 2024
ca1f6c3
Merging
armine-fliplet Dec 27, 2024
161a675
Add changes for testing
armine-fliplet Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions interface.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,10 +1872,13 @@ <h4><small>App submission status</small></h4>
<div class="app-build-progress-holder"><i class="fa fa-check-circle"></i> Completed</div>
\{{#if fileUrl}}
<div class="download-build"><a href="\{{fileUrl}}"><i class="fa fa-download"></i> Download file</a></div>\{{/if}}
\{{#if isAdmin}}
\{{#if debugFileUrl}}
<div class="download-build"><span class="label label-default">Admin</span> <a href="\{{debugFileUrl}}"><i class="fa fa-download"></i> Download debug app</a> <a href="https://support.apple.com/en-us/HT204460"><i class="fa fa-fw fa-question-circle-o"></i></a></div>
\{{else}}
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>\{{/if}}
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>
\{{/if}}
\{{/if}}
</td>
<td class="app-build-details">
\{{#if updatedAt}}<span><span class="icon"><i class="fa fa-flag-checkered"></i> Finished on:</span> \{{updatedAt}}</span>\{{/if}}
Expand All @@ -1887,10 +1890,13 @@ <h4><small>App submission status</small></h4>
<div class="app-build-progress-holder"><i class="fa fa-bell"></i> \{{testingStatus}}</div>
\{{#if fileUrl}}
<div class="download-build"><a href="\{{fileUrl}}"><i class="fa fa-download"></i> Download file</a></div>\{{/if}}
\{{#if isAdmin}}
\{{#if debugFileUrl}}
<div class="download-build"><span class="label label-default">Admin</span> <a href="\{{debugFileUrl}}"><i class="fa fa-download"></i> Download debug app</a> <a href="https://support.apple.com/en-us/HT204460"><i class="fa fa-fw fa-question-circle-o"></i></a></div>
\{{else}}
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>\{{/if}}
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>
\{{/if}}
\{{/if}}
</td>
<td class="app-build-details">
\{{#if updatedAt}}<span><span class="icon"><i class="fa fa-clock-o"></i> Ready on:</span> \{{updatedAt}}</span>\{{/if}}
Expand Down Expand Up @@ -1927,7 +1933,7 @@ <h4><small>App submission status</small></h4>
\{{#if updatedAt}}<span><span class="icon"><i class="fa fa-flag-checkered"></i> Finished on:</span> \{{updatedAt}}</span>\{{/if}}
<div class="app-build-name">\{{{message}}}</div>
</td>
\{{/if}}
\{{/if}}
\{{#if cancelled}}
<td class="app-build-progress warning">
<div class="app-build-progress-holder"><i class="fa fa-ban"></i> Canceled</div>
Expand Down
7 changes: 5 additions & 2 deletions js/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2155,8 +2155,9 @@ function checkSubmissionStatus(origin, iosSubmissions) {

if (submission.result.message) {
build.message = submission.result.message;

const gracefullyFailedMessage = "The app has been uploaded to the App Store Connect but could not be submitted for review. Please log in on https://appstoreconnect.apple.com/ to finish up the process and submit the app for review.";

const gracefullyFailedMessage = 'The app has been uploaded to the App Store Connect but could not be submitted for review. Please log in on https://appstoreconnect.apple.com/ to finish up the process and submit the app for review.';

if (submission.result.message === gracefullyFailedMessage) {
submission.status = 'gracefullyFailed';
}
Expand All @@ -2169,6 +2170,8 @@ function checkSubmissionStatus(origin, iosSubmissions) {
}

if (userInfo && userInfo.user && (userInfo.user.isAdmin || userInfo.user.isImpersonating)) {
build.isAdmin = userInfo.user.isAdmin || userInfo.user.isImpersonating;
console.log('build.isAdmin', build.isAdmin);
build.debugFileUrl = debugHtmlPage ? removeAuthTokenFromFileUrl(debugHtmlPage.url) : '';
}

Expand Down