In the cases that we don't have the credentials object, p12 fetch fixed #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now fetch the first completed submission that has the correct certification values (in store) or published on Enterprise.
squallstar
reviewed
Mar 13, 2018
| return submission.status === "completed"; | ||
| }); | ||
|
|
||
| //Get the Submission data from the first completed submission, it has the certification values that are in use on the app store. |
Contributor
There was a problem hiding this comment.
why the first one? previous should be current-1, right?
Contributor
Author
There was a problem hiding this comment.
As the comment says @squallstar "Get the Submission data from the first completed submission, it has the certification values that are in use on the app store." This will prevent us from fetching wrong p12 data that was obtained from a submission done with another p12 besides the first one. It is more of an issue for the Enterprise submission that it is for the App Store, so Ikept as it is for both.
squallstar
approved these changes
Mar 13, 2018
Contributor
squallstar
left a comment
squallstar
left a comment
There was a problem hiding this comment.
@tonytlwu passing to you
tonytlwu
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now fetch the first completed submission that has the correct
certification values (in store) or published on Enterprise.