Rebuilt 'App Analytics & Push' tab and added Firebase config feature. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytlwu
approved these changes
Sep 11, 2019
Contributor
tonytlwu
left a comment
tonytlwu
left a comment
There was a problem hiding this comment.
@sofiiakvasnevska This is ready for testing
Risk: High
Affected: Users submitting Android app builds
Verify: Users can submit Android app builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tonytlwu @squallstar
Issue
https://github.com/Fliplet/fliplet-studio/issues/4965
Description
Rebuilt tab 'App Analytics & Push', changed it content and added Firebase config feature.
Screenshots/screencasts
Backward compatibility
This change is fully backward compatible.
Notes
Code for processing firebase file was taking from this PR Fliplet/fliplet-widget-app-submission#104