Skip to content

Conversation

@Zeroto521
Copy link
Member

@Zeroto521 Zeroto521 commented Sep 22, 2020

We need to check the information of setup.py.

The next step is to add docs for FlowLauncher.py, FlowLauncherAPI.py.

@Zeroto521
Copy link
Member Author

@jjw24 Hi, how does the Python code review?

I know there are some C# code reviewers.

But for the Python project, It needs other reviewers to check or just let me merge this pull request directly?

@jjw24
Copy link
Member

jjw24 commented Oct 11, 2020

@jjw24 Hi, how does the Python code review?

I know there are some C# code reviewers.

But for the Python project, It needs other reviewers to check or just let me merge this pull request directly?

Hey @Zeroto521 , thanks for the great work. It would be the ideal approach for a peer review before merging, in the meantime it is ok for you just to merge in as I don't want this to be the blocker for your progress. When I have capacity I will jump in to help out with the review. So for now, it would help you progress with your changes by just merging in directly.

@Zeroto521 Zeroto521 merged commit 73f3afc into Flow-Launcher:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants