Skip to content

Add try-catch when reading file stream #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add try-catch when reading file stream #3741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions Flow.Launcher.Infrastructure/Storage/BinaryStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,17 @@ public async ValueTask<T> TryLoadAsync(T defaultData)
await SaveAsync();
}

await using var stream = new FileStream(FilePath, FileMode.Open);
Data = await DeserializeAsync(stream, defaultData);
try
{
await using var stream = new FileStream(FilePath, FileMode.Open);
Data = await DeserializeAsync(stream, defaultData);
}
catch (System.Exception e)
{
Log.Exception(ClassName, $"Failed to load stream and deserialize for <{FilePath}>", e);
Data = defaultData;
return defaultData;
}
}
else
{
Expand All @@ -81,16 +90,8 @@ public async ValueTask<T> TryLoadAsync(T defaultData)

private static async ValueTask<T> DeserializeAsync(Stream stream, T defaultData)
{
try
{
var t = await MemoryPackSerializer.DeserializeAsync<T>(stream);
return t ?? defaultData;
}
catch (System.Exception)
{
// Log.Exception($"|BinaryStorage.Deserialize|Deserialize error for file <{FilePath}>", e);
return defaultData;
}
var t = await MemoryPackSerializer.DeserializeAsync<T>(stream);
return t ?? defaultData;
}

public void Save()
Expand Down
Loading