chore: migrate from deprecated packages, add dependabot job #96
Conversation
junners
left a comment
junners
left a comment
There was a problem hiding this comment.
Wow! You went incredibly deep on this! Thank you so much for your contribution!
| "target": "es2019", | ||
| "lib": ["es2020"], | ||
| "moduleResolution": "Node16", | ||
| "module": "Node16", |
There was a problem hiding this comment.
I'll have to check whether sf cli can consume this
There was a problem hiding this comment.
I think it should, the reason I changed it in this specific way is because of the dev-config here: https://github.com/forcedotcom/dev-config/blob/main/tsconfig-esm.json
The template that Salesforce provides for CLI plugins extends this config by default.
| char: 'u', | ||
| description: 'Retrieve the latest metadata from the target before the scan.', | ||
| required: false, | ||
| }) |
There was a problem hiding this comment.
Another thing to note: I'm not sure what happened to the targetusername flag? I think an older version of @salesforce/core had this as a default flag for all commands, but now we need to explicitly create it.
There was a problem hiding this comment.
Hmmm gotcha. I haven't used this with flow scanner due to my usage contained in the scanning directory. All invocations of sf cli core gets the default username property to set the target org
There was a problem hiding this comment.
But yea you're absolutely right, scan.ts has defaultusername which calls retrive on org
|
I've bumped all the dependencies here as well as added an alias -o for the -u flag since the wider sf cli uses -o for target org |
|
Always appreciate the support and contribution @k-capehart ❤️ |
|
🎉 This PR is included in version 2.27.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…_yarn-multi-351a35f700 fix(deps): bump mocha and @types/mocha
Somehow I went down this rabbit hole of updating packages, and realized we had a number of deprecated dependencies.
Naturally, I then had to make some updates to the
scancommand to match the new dependencies. I ran into some issues with CommonJS, so migrated the projected to an ES Module. I'm not 100% confident in that decision, but it fixed the problem after some more configuring.Lastly, I added a
dependabot.yamlso we can get notified of dependency updates and maybe avoid problems like this in the future. I followed the documentation here: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates