Skip to content

Try to fix google chat live test #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2023
Merged

Try to fix google chat live test #5039

merged 3 commits into from
Mar 25, 2023

Conversation

rrrooommmaaa
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa commented Mar 25, 2023 •
edited by sosnovsky
Loading

This PR tries to fix Javascript world error

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@rrrooommmaaa rrrooommmaaa marked this pull request as ready for review March 25, 2023 13:09
@rrrooommmaaa rrrooommmaaa requested a review from sosnovsky as a code owner March 25, 2023 13:09
@rrrooommmaaa rrrooommmaaa enabled auto-merge (squash) March 25, 2023 13:09
@rrrooommmaaa rrrooommmaaa merged commit 207443f into master Mar 25, 2023
@rrrooommmaaa rrrooommmaaa deleted the issue-0000-fix-google-chat-live-test branch March 25, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrrooommmaaa @sosnovsky