Skip to content

Try to fix google chat live test #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2023
Merged

Try to fix google chat live test #5039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cb941d
fix Javascript world error
Mar 25, 2023
016950c
try #2
Mar 25, 2023
6e38289
try number 3
Mar 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/source/browser/controllable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,9 @@ abstract class ControllableBase {
} catch (e) {
this.log(`wait_and_click(i${i}):6:err(${String(e)}):${selector}`);
if (
e.message === 'Node is either not visible or not an HTMLElement' ||
e.message === 'Node is either not clickable or not an HTMLElement' ||
e.message === 'Node is detached from document'
['Node is either not visible or not an HTMLElement', 'Node is either not clickable or not an HTMLElement', 'Node is detached from document'].includes(
e.message
)
) {
// maybe the node just re-rendered?
if (!retryErrs || i === 3) {
Expand Down
6 changes: 5 additions & 1 deletion test/source/tests/page-recipe/oauth-page-recipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,11 @@ export class OauthPageRecipe extends PageRecipe {
}
} catch (e) {
const eStr = String(e);
if (!eStr.includes('Execution context was destroyed') && !eStr.includes('Cannot find context with specified id')) {
if (
!eStr.includes('Execution context was destroyed') &&
!eStr.includes('Cannot find context with specified id') &&
!eStr.includes('Argument should belong to the same JavaScript world as target object')
) {
throw e; // not a known retriable error
}
// t.log(`Attempting to retry google auth:${action} on the same window for ${email} because: ${eStr}`);
Expand Down