Skip to content

Properties update refactor needed #31

@paodb

Description

@paodb

It has come to my attention that there's no need to have these properties defined in the Carousel class:

 private boolean autoProgress;
 private int slideDuration = DEFAULT_SLIDE_DURATION;
 private int startPosition;
 private boolean disableSwipe;
 private boolean hideNavigation;

See

These properties are then used in setter methods and do nothing to update the component. Component will be updated only when calling updateProperties method. The setter methods they should just update the attributes directly in the element as this.getElement().setAttribute(...);

This comes from issue #29.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions