Panorama images are not cropped correctly (cropped image too small)

[realulim]

Describe the bug

With panorama images I mean images that are wider than the available screen pixels.

Let's assume a panorama image of 2000x1000 pixels and let's further assume that we initialize the plugin with a crop frame of at least 500x500 pixels. And let's assume that we have 1500 pixels of screen space for the image within the crop dialog.

In that case the original image is scaled down to 1500x750 pixels, so that no horizontal scrollbar appears. If I now crop the image keeping the crop size at the minimum dimensions, then I do not get a cropped image of 500x500 pixels, but one of 375x375 pixels.

If I have understood the code correctly, then this means that the crop is not taken from the original image, but from the scaled down version.

Expected behavior

I would expect that the crop is always taken from the original image, not from a scaled down version, and that the size of the cropped image is as specified.

In this example I would expect a cropped image of 500x500 pixels showing approximately the same excerpt of the image that was selected by the 375x375 crop frame.

Minimal reproducible example

No response

Add-on Version

1.1.2

Vaadin Version

24.7.11

Additional information

No response

[paodb]

Hi @realulim,

Thank you for this bug report. We appreciate you taking the time to help us improve our component.

To move forward, we need your help. Our engineering team cannot reproduce the issue with the description provided alone. To efficiently diagnose and fix the problem, a minimal reproducible example (MRE) is essential. We are ready and willing to investigate as soon as you can provide one.

Here is a guides on how to create an MRE: https://stackoverflow.com/help/minimal-reproducible-example

Thank you for your partnership in solving this.

[realulim]

It is possible to reproduce from the demo application. All you need to do is to replace lines 104-108 in UploadImageCropDemo.java with the following code:

    int minWidth = 500, minHeight = 500;
    imageCrop = new ImageCrop(src);
    imageCrop.setCropMinWidth(minWidth);
    imageCrop.setCropMinHeight(minHeight);
    imageCrop.setCircularCrop(false);
    imageCrop.setAspect((double)minWidth / (double)minHeight);
    imageCrop.setCrop(new Crop("px", 0, 0, minWidth, minHeight));
    imageCrop.setKeepSelection(true);
    imageCrop.setImageFullHeight(false);

Then try to upload a panorama image (I will attach a "green screen" example image of 4000x500 pixels that should reproduce the issue for most screen resolutions. But if your screen is wider than 4000 pixels, you need to create a wider image). The crop rectangle will appear and if you crop, then the cropped image will be less than 500x500 pixels, even though that was set as the minimum size.

[realulim]