-
Notifications
You must be signed in to change notification settings - Fork 1
deprecate: deprecate ImageCrop(Image)
constructor
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe project version in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pom.xml
(1 hunks)src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java
(1 hunks)
🔇 Additional comments (2)
pom.xml (1)
7-7
: LGTM! Appropriate version increment for deprecation.The minor version bump from
1.1.3-SNAPSHOT
to1.2.0-SNAPSHOT
correctly follows semantic versioning practices when introducing deprecations while maintaining backward compatibility.src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java (1)
74-78
: LGTM! Proper deprecation implementation.The deprecation annotation correctly specifies
forRemoval = true
andsince = "1.2.0"
, aligning with the version update inpom.xml
. The constructor implementation remains unchanged, preserving backward compatibility while clearly signaling the deprecation to developers.
src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java
Outdated
Show resolved
Hide resolved
82ad661
to
ee07d74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #24
Summary by CodeRabbit
Chores
Deprecations