0.9.0 release candidate #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughUpdated project metadata and docs, added license headers and formatting cleanups, introduced JsonSerializer and new JsonCodec helpers, added typed result handling in ElementalPendingJavaScriptResult, and applied test updates including new imports and additional assertions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalPendingJavaScriptResult.java (1)
40-40: Replace import with localJsonCodecabstraction.Change
import com.vaadin.flow.internal.JsonCodec;toimport com.flowingcode.vaadin.jsonmigration.JsonCodec;on line 40.The local
JsonCodecclass provides the samedecodeAsmethod signature and is specifically designed to abstract Vaadin version differences. Using Vaadin's internal API (com.vaadin.flow.internal) bypasses this abstraction and introduces version compatibility risks that the project aims to avoid.
🧹 Nitpick comments (6)
src/main/java/com/flowingcode/vaadin/jsonmigration/InstrumentationViewInitializer.java (1)
50-53: Consider usingString.format()for the exception message.The multi-line string concatenation is functional and readable, but modern Java conventions would suggest
String.format()for improved clarity and maintainability.- throw new IllegalArgumentException( - navigationTarget.getName() - + " must be annotated with @" - + InstrumentedRoute.class.getSimpleName()); + throw new IllegalArgumentException( + String.format("%s must be annotated with @%s", + navigationTarget.getName(), + InstrumentedRoute.class.getSimpleName()));src/main/java/com/flowingcode/vaadin/jsonmigration/JsonCodec.java (2)
117-144: Minor: Javadoc mentionsNumberbut implementation handles onlyIntegerandDouble.The Javadoc at line 119 states "Supported values types are {@link String}, {@link Number}, {@link Boolean}, {@link JsonValue}" but the implementation (lines 135-136) only handles
IntegerandDouble, not otherNumbersubclasses likeLongorFloat. Consider updating the Javadoc for accuracy or extending support.- * Helper for encoding any "primitive" value that is directly supported in JSON. Supported values - * types are {@link String}, {@link Number}, {@link Boolean}, {@link JsonValue}. <code>null</code> + * Helper for encoding any "primitive" value that is directly supported in JSON. Supported values + * types are {@link String}, {@link Integer}, {@link Double}, {@link Boolean}, {@link JsonValue}. <code>null</code>
132-134: Minor inconsistency:typevariable already holdsvalue.getClass().Line 133 uses
value.getClass()buttypewas just assignedvalue.getClass()on line 132.Class<?> type = value.getClass(); - if (String.class.equals(value.getClass())) { + if (String.class.equals(type)) { return Json.create((String) value);src/main/java/com/flowingcode/vaadin/jsonmigration/JsonSerializer.java (3)
206-215:Class.newInstance()is deprecated since Java 9.Using the deprecated
newInstance()method. PrefergetDeclaredConstructor().newInstance()for consistency with the rest of the codebase (as seen in test files) and to handle exceptions more explicitly.T instance; try { - instance = type.newInstance(); + instance = type.getDeclaredConstructor().newInstance(); } catch (Exception e) { throw new IllegalArgumentException( "Could not create an instance of type "
360-368:Class.newInstance()is deprecated since Java 9.Same as the other location — prefer
getDeclaredConstructor().newInstance().try { - return (Collection<?>) collectionType.newInstance(); + return (Collection<?>) collectionType.getDeclaredConstructor().newInstance(); } catch (Exception e) {
271-274: Returningnullfor non-array JSON may be unexpected.When
json.getType() != JsonType.ARRAY, returningnullsilently may mask errors. Consider throwing anIllegalArgumentExceptionto signal misuse, or document this behavior explicitly in the calling method's Javadoc.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (103)
.github/ISSUE_TEMPLATE/bug-report.yml(1 hunks).github/ISSUE_TEMPLATE/feature-request.yml(1 hunks)README.md(1 hunks)pom.xml(1 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ClassInstrumentationJacksonHelper.java(1 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ClassInstrumentationUtil.java(17 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalArrayNode.java(0 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalBooleanNode.java(0 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNullNode.java(0 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNumberNode.java(0 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalObjectNode.java(1 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalPendingJavaScriptResult.java(2 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalStringNode.java(1 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/InstrumentationViewInitializer.java(2 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/InstrumentedRoute.java(0 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/JsonCodec.java(2 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigration.java(7 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper.java(1 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper25.java(6 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/JsonSerializer.java(1 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable.java(2 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/LegacyJsonMigrationHelper.java(4 hunks)src/main/java/com/flowingcode/vaadin/jsonmigration/UnsupportedJsonValueImpl.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/BaseClientCallable.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_D__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_I__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonArray__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonBoolean__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonNull__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonNumber__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonObject__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonString__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonValue__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_String__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_Z__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__D.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__I.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__Integer.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonArray.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonBoolean.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonNull.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonNumber.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonObject.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonString.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonValue.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__Z.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest.java(14 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest24.java(2 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest25.java(2 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/ExtendsLegacyClientCallablePrivate__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_D__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_I__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonArray__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonBoolean__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonNull__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonNumber__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonObject__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonString__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonValue__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_String__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_Z__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__D.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__I.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__Integer.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonArray.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonBoolean.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonNull.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonNumber.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonObject.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonString.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonValue.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__Z.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_D__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_I__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonArray__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonBoolean__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonNull__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonNumber__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonObject__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonString__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonValue__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_String__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_Z__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__D.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__I.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__Integer.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonArray.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonBoolean.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonNull.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonNumber.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonObject.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonString.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonValue.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__V.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__Z.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest.java(7 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest24.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest25.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest.java(14 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest24.java(1 hunks)src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest25.java(1 hunks)
💤 Files with no reviewable changes (5)
- src/main/java/com/flowingcode/vaadin/jsonmigration/InstrumentedRoute.java
- src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalArrayNode.java
- src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalBooleanNode.java
- src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNullNode.java
- src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNumberNode.java
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: javier-godoy
Repo: FlowingCode/JsonMigrationHelper PR: 11
File: src/main/java/com/flowingcode/vaadin/jsonmigration/JsonSerializer.java:281-301
Timestamp: 2025-11-25T16:35:42.544Z
Learning: In the JsonMigrationHelper project, code copied from the Vaadin codebase should be kept consistent with the original source unless there's a specific reason to deviate.
📚 Learning: 2025-11-25T16:35:42.544Z
Learnt from: javier-godoy
Repo: FlowingCode/JsonMigrationHelper PR: 11
File: src/main/java/com/flowingcode/vaadin/jsonmigration/JsonSerializer.java:281-301
Timestamp: 2025-11-25T16:35:42.544Z
Learning: In the JsonMigrationHelper project, code copied from the Vaadin codebase should be kept consistent with the original source unless there's a specific reason to deviate.
Applied to files:
src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonValue.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonNull__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest25.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest24.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/InstrumentationViewInitializer.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__Integer.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonString.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_D__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonString__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonArray__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__D.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_Z__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__D.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest24.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonObject__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__D.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonValue.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/ElementalObjectNode.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper25.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__Z.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonObject.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonString__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonArray.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_I__V.javaREADME.mdsrc/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigration.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonNull.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/ClassInstrumentationUtil.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_D__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_Z__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__I.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonObject.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonNumber__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonString.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonNull.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_I__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonValue__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonArray.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonNumber.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonNumber.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__Z.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest25.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonBoolean.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonNumber.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__I.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonObject.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonNumber__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonValue__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__Integer.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/JsonSerializer.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__Z.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonNumber__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonNull.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonBoolean.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_D__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonArray__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/BaseClientCallable.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonArray__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonBoolean__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonBoolean__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_Z__V.javapom.xmlsrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonNull__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonObject__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__Integer.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonValue__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonString.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonArray.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_String__V.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/LegacyJsonMigrationHelper.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_I__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonValue.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_String__V.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/ClassInstrumentationJacksonHelper.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonBoolean.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonObject__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ExtendsLegacyClientCallablePrivate__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonString__V.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonBoolean__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__I.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonNull__V.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest24.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_String__V.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/JsonCodec.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/UnsupportedJsonValueImpl.javasrc/main/java/com/flowingcode/vaadin/jsonmigration/ElementalPendingJavaScriptResult.javasrc/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest25.java
🧬 Code graph analysis (4)
src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper25.java (2)
src/main/java/com/flowingcode/vaadin/jsonmigration/JsonCodec.java (1)
JsonCodec(64-145)src/main/java/com/flowingcode/vaadin/jsonmigration/LegacyJsonMigrationHelper.java (1)
SuppressWarnings(68-73)
src/main/java/com/flowingcode/vaadin/jsonmigration/JsonSerializer.java (6)
src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalObjectNode.java (1)
SuppressWarnings(33-60)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalStringNode.java (1)
SuppressWarnings(25-36)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNullNode.java (1)
SuppressWarnings(25-41)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalBooleanNode.java (1)
SuppressWarnings(25-36)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNumberNode.java (1)
SuppressWarnings(25-46)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalArrayNode.java (1)
SuppressWarnings(31-57)
src/main/java/com/flowingcode/vaadin/jsonmigration/JsonCodec.java (8)
src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalObjectNode.java (1)
SuppressWarnings(33-60)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalStringNode.java (1)
SuppressWarnings(25-36)src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper25.java (1)
SuppressWarnings(223-276)src/main/java/com/flowingcode/vaadin/jsonmigration/LegacyJsonMigrationHelper.java (1)
SuppressWarnings(68-73)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNullNode.java (1)
SuppressWarnings(25-41)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalBooleanNode.java (1)
SuppressWarnings(25-36)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNumberNode.java (1)
SuppressWarnings(25-46)src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalArrayNode.java (1)
SuppressWarnings(31-57)
src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalPendingJavaScriptResult.java (1)
src/main/java/com/flowingcode/vaadin/jsonmigration/JsonCodec.java (1)
JsonCodec(64-145)
paodb
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
-addonChecklist for the initial commit
General
The repository depends on the latest released and generally available version of Vaadin.SEE NOTEPOM
<artifactId>has been replaced<artifactId>is suffixed with-addon<inceptionYear>is set to the current year.<name>and<description>.<description>focuses on the component's function and benefit to the user.<scm>URLs point to this repository.README
-addon.ISSUE_TEMPLATE
License
Documentation
Demos
Run the application locally to ensure demos are working as expected and check if sources are being displayed correctly.DOES NOT APPLY
Tests
CI
Dependency has been added to AddonsDemoDOES NOT APPLYSummary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.