Chore/removing child mode #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemati
pushed a commit
to hemati/Flowise
that referenced
this pull request
Dec 27, 2023
Chore/removing child mode
JohnBQuinn
pushed a commit
to JohnBQuinn/Flowise
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't see significant improvement when using child mode.
Flowise on main mode is still be able to handle parallel chats due to the nature of NodeJS of single-threaded async functionality.
Using child mode is beneficial if you are running heavy computational task like complicated math calculation, but in Flowise we don't have that.
In future, can implement queue using Redis for horizontal scalling