Skip to content

Conversation

@wkwiatek
Copy link
Contributor

Closes #247, #226

@netlify
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit 151d013
🔍 Latest deploy log https://app.netlify.com/sites/pvm-debugger/deploys/678de6e5923b010008cfbe67
😎 Deploy Preview https://deploy-preview-262--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wkwiatek wkwiatek marked this pull request as ready for review December 28, 2024 06:41
@tomusdrw
Copy link
Contributor

Getting errors when selecting a PVM and refreshing the page. It seems that it forgets about https:// for the URL?
image

@wkwiatek
Copy link
Contributor Author

@tomusdrw indeed, looks like the path was corrupted but in the way that worked locally and not on the remote server. Did a dirty workaround (but continuing to find the root cause).

To make it work now, please clear the LS (persist:debugger key specifically):
image

Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from loading from URL (reported separately as #288)

@wkwiatek wkwiatek merged commit f7d52f1 into main Jan 20, 2025
6 checks passed
@wkwiatek wkwiatek deleted the feature/save-pvms branch January 20, 2025 06:15
@tomusdrw tomusdrw mentioned this pull request Feb 4, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remember selected and uploaded PVMs

3 participants