Skip to content

Conversation

@jacobaraujo7
Copy link
Contributor

Description

Fix: Inject.get should return instance.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@jacobaraujo7 jacobaraujo7 self-assigned this May 12, 2022
@jacobaraujo7 jacobaraujo7 linked an issue May 12, 2022 that may be closed by this pull request
@jacobaraujo7 jacobaraujo7 changed the title Fix: Inject.get should return instance. fix: Inject.get should return instance. May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #709 (65d8490) into master (57413a5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #709   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          774       767    -7     
=========================================
- Hits           774       767    -7     
Impacted Files Coverage Δ
flutter_modular/lib/flutter_modular.dart 100.00% <100.00%> (ø)
...dular/lib/src/presenter/widgets/widget_module.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce79b6...65d8490. Read the comment docs.

Copy link
Contributor

@AlvaroVasconcelos AlvaroVasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@jacobaraujo7 jacobaraujo7 merged commit 00a98b8 into master May 12, 2022
@jacobaraujo7 jacobaraujo7 deleted the fix_inject branch May 12, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ERROR BREAKING CHANGE MODULAR 5.0]

3 participants