Skip to content

feat: prepare to publish #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2022
Merged

feat: prepare to publish #736

merged 4 commits into from
Jun 3, 2022

Conversation

@jacobaraujo7
Copy link
Contributor

@jacobaraujo7 jacobaraujo7 commented Jun 2, 2022 •
edited
Loading

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@jacobaraujo7 jacobaraujo7 self-assigned this Jun 2, 2022
@jacobaraujo7 jacobaraujo7 added the bug Something isn't working label Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #736 (fc406ce) into master (4982c98) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #736   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          775       775           
=========================================
  Hits           775       775

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c3a8d...fc406ce. Read the comment docs.

This was linked to issues Jun 3, 2022
[flutter_modular] Can't access a AsyncBind as a synchronous bind from a imported module after using isModuleReady on latest version of Modular. #713
Closed
Widget Module not properly disposed on modular 4.5.0 #676
Closed
AlvaroVasconcelos
AlvaroVasconcelos reviewed Jun 3, 2022
View reviewed changes
AlvaroVasconcelos
AlvaroVasconcelos approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@AlvaroVasconcelos AlvaroVasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@AlvaroVasconcelos AlvaroVasconcelos merged commit 3567303 into master Jun 3, 2022
@jacobaraujo7 jacobaraujo7 deleted the publish-modular-5.0.3 branch June 3, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pauloantonelli pauloantonelli pauloantonelli approved these changes

@AlvaroVasconcelos AlvaroVasconcelos AlvaroVasconcelos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jacobaraujo7 jacobaraujo7

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

4 participants

@jacobaraujo7 @pauloantonelli @AlvaroVasconcelos