added getters in command #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wellgenio
requested changes
Dec 12, 2024
Contributor
There was a problem hiding this comment.
@rodrigorafaeldamaceno add usage examples in the README and docs
Contributor
Author
|
@wellgenio I updated the examples in README and added isFailure getter |
Contributor
|
@rodrigorafaeldamaceno keep the old README examples too and add the example comments: /// Checks if the current command is running.
bool get isRunning => value is RuningCommand<T>; |
Contributor
Author
|
@wellgenio I updated the README with a Getters section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces getter methods to the Command class, enhancing the clarity and readability of state checks when used in views. By encapsulating the logic for determining command states (isIdle, isRunning, isCancelled, and isSuccess) into dedicated getters, the code becomes more concise and expressive.
These changes aim to improve the developer experience by providing a cleaner and more intuitive interface for interacting with Command objects, reducing boilerplate and improving maintainability. This enhancement is particularly beneficial when building user interfaces, as it simplifies state-driven UI updates and aligns with best practices for state management in Flutter applications.