Unified Scale projections and fixed black border #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This fixes #102 |
h-spiess
changed the title
Contributor
Author
|
Example from tests on master vs. this commit: current master: this commit: |
paulnovo
reviewed
Oct 23, 2025
Collaborator
paulnovo
left a comment
paulnovo
left a comment
There was a problem hiding this comment.
Thank you, this is great. Consolidating the scale projections makes a lot of sense. I added just one comment/question.
…ling transformations
paulnovo
reviewed
Oct 28, 2025
Collaborator
paulnovo
left a comment
paulnovo
left a comment
There was a problem hiding this comment.
Thanks for digging into the bounds ranges, this is really great. I just left a couple of small comments and tweaks. But this is looking ready to go.
Contributor
Author
|
upsie. i ran the tests locally. not sure what happened here. i will fix it |
paulnovo
approved these changes
Nov 5, 2025
Collaborator
paulnovo
left a comment
paulnovo
left a comment
There was a problem hiding this comment.
This is great, thank you! You should be able to merge, but if not, let me know.
Contributor
Author
|
Seems that I can’t merge or I’m missing something. At least there is no option in this UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale projections had seperate implementations where the black border was only fixed for
ScaleFixed. Unified implementations and fixed black borders for all projections.PR Checklist