Fix caching #82
Closed
Fix caching #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
There was a problem hiding this comment.
Why this change? Your code is functionally identical to the shorter, simpler code that was there before?
Author
There was a problem hiding this comment.
The performance was pretty bad so I tried to improve it. But you're right this probably doesn't change much.
Owner
|
I'm closing this as it has now been fixed by moving over to watchify. Would you like to be added as a collaborator on this project, to help review and merge pull requests? |
Author
|
If you think I can help, sure! I'd be happy to! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a large dependency tree and it crashed everytime with stackoverflow error.
This was because of too many recursive calls of
getDeps.Also the whole method seemed to be pretty broken and did not return the correct dependencies.