fix(introspection): editable attribute now determine is_readonly (#168)

Author: jbarreau

src/_example/django/django_demo/app/flask_models.py

@@ -29,7 +29,7 @@ class FlaskCustomer(models.Model):
     birthday_date = models.DateTimeField(blank=True, null=True)
     age = models.IntegerField(blank=True, null=True)
     is_vip = models.BooleanField(blank=True, null=True)
-    avatar = models.BinaryField(blank=True, null=True)
+    avatar = models.BinaryField(blank=True, null=True, editable=True)
     addresses = models.ManyToManyField("FlaskAddress", through="FlaskCustomersAddresses", related_name="customers")
 
     class Meta:

src/_example/django/django_demo/app/models.py

@@ -98,7 +98,7 @@ class Customer(AutoUpdatedCreatedAt):
     # age = should_be computed
     # addresses = models.ManyToManyField(Address, related_name="customers")
     is_vip = models.BooleanField(default=False)
-    avatar = models.BinaryField(null=True, blank=True)
+    avatar = models.BinaryField(null=True, blank=True, editable=True)
 
 
 class Order(AutoUpdatedCreatedAt):

src/datasource_django/forestadmin/datasource_django/utils/model_introspection.py

@@ -50,7 +50,7 @@ def _build_is_read_only(field: Field) -> bool:
             return field.auto_now is True or field.auto_now_add is True
         if GeneratedField is not None and isinstance(field, GeneratedField):
             return True
-        return False
+        return not field.editable
 
     @classmethod
     def _build_validations(cls, field: Field) -> List[Validation]:

src/datasource_django/tests/utils/test_django_model_introspection.py

@@ -66,6 +66,20 @@ def test_build_should_handle_read_only_for_date_auto_now(self):
 
         self.assertEqual(field_schema["is_read_only"], True)
 
+    def test_build_should_handle_read_only_field_is_editable(self):
+        """readonly"""
+        field = models.CharField(max_length=254, editable=False)
+        field_schema = FieldFactory.build(field)
+
+        self.assertEqual(field_schema["is_read_only"], True)
+
+    def test_build_should_handle_read_only_field_is_not_editable(self):
+        """readonly"""
+        field = models.CharField(max_length=254, editable=True)
+        field_schema = FieldFactory.build(field)
+
+        self.assertEqual(field_schema["is_read_only"], False)
+
     def test_build_should_handle_present_validator(self):
         """validator"""
         field = models.DateField()