fix(resources-remover): support scopes targeting relation fields#1142
Merged
matthv merged 1 commit intoMay 12, 2026
Merged
Conversation
matthv
deleted the
fix/prd-344-bug-forest-express-sequelize-deleteupdate-fail-when-a-scope
branch
forest-bot
added a commit
that referenced
this pull request
May 12, 2026
## [9.6.3](v9.6.2...v9.6.3) (2026-05-12) ### Bug Fixes * **resources-remover:** support scopes targeting relation fields ([#1142](#1142)) ([5717ab8](5717ab8))
Member
|
🎉 This PR is included in version 9.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ResourcesRemoverto support scopes targeting relation fieldsQueryOptionsproduces aninclude(e.g. a scope filtered on a related model's column),perform()now runs afindAllto resolve matching primary keys and then callsdestroywith those PKs, instead of passingincludedirectly toModel.destroy._destroyByPrimaryKeyto handle the select-then-delete flow, and_buildPrimaryKeyWhereto construct the correctWHEREclause for both single and composite primary keys.destroyis skipped andperform()returns0.includedirectly toModel.destroy(which Sequelize silently ignores) now correctly filter and delete only matching rows.Macroscope summarized fb24d05.