Release PR #561
Open
Release PR #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
9ebc1d3 to
dcd0246
Compare
|
View your CI Pipeline Execution ↗ for commit 6a0c006
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
=========================================
Coverage ? 56.64%
=========================================
Files ? 105
Lines ? 31600
Branches ? 1741
=========================================
Hits ? 17899
Misses ? 13701
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fixes an issue reported by a user with a bad export syntax.
- revert small change to ping-protect package.json - fix e2e tests - conditionally add "agent" properties on callback only when present
- revert small change to ping-protect package.json - fix e2e tests - conditionally add "agent" properties on callback only when present
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
6a0c006 to
dfa665d
Compare
ancheetah
approved these changes
Nov 20, 2025
Contributor
ancheetah
left a comment
ancheetah
left a comment
There was a problem hiding this comment.
@ryanbas21 lgtm. What was the issue you were having with the closed release PR? They look the same to me. I'll leave it up to Justin to check that all the protect work is there.
brando-dill
approved these changes
Nov 20, 2025
brando-dill
left a comment
brando-dill
left a comment
There was a problem hiding this comment.
LGTM. This is for Legacy JS SDK 4.8.3 for the new signals package so this is good. Add me to the 1.3 Protect Support with DaVinci PR as well.
cerebrl
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
@forgerock/javascript-sdk@4.8.3
Patch Changes
f35d9b2Thanks @ryanbas21! - fixes a bad export syntax in package.json90099e5Thanks @cerebrl! - This aligns ping-protect and protect initialize callbacks to the new Journey Nodes@forgerock/ping-protect@4.6.2
Patch Changes
90099e5Thanks @cerebrl! - This aligns ping-protect and protect initialize callbacks to the new Journey NodesUpdated dependencies [
f35d9b2,90099e5]: