fix: rollback client router (PR #281) #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this break the back buttons
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yoannfleurydev
approved these changes
Mar 19, 2025
antoinekm
added a commit
to ArkeeAgency/forkit.community
that referenced
this pull request
Mar 19, 2025
antoinekm
added a commit
to ArkeeAgency/forkit.community
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback the PR #281 (sorry @antoinekm 😅)
Because this break the back buttons. With the client router we don't have a document.referrer and we cannot have the smart back button (history.back() if the document.referrer contains the website host).
The back button behavior (be able to keep the scroll position when clicking on back button with history.back) is more important than the smooth transitions for the UX.
If someone have an idea of how to keep the 2 behaviors, please tell us 🙏