This repository was archived by the owner on Mar 4, 2022. It is now read-only.
Misc updates: global require, Ctrl-c + SIGINT #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.screen.ignoreLocked = ["C-c"]; | ||
| this.screen.key("C-c", () => { | ||
| process.exit(0); // eslint-disable-line no-process-exit | ||
| process.kill(process.pid, "SIGINT"); |
There was a problem hiding this comment.
Yep this looks right! The only thing we did different in webpack-dashboard was listen for "escape" and "q" as valid keys to trigger sending SIGINT. We could consider doing that here as well.
Member
Author
There was a problem hiding this comment.
Good idea! Added #106 to allow some discussion first.
parkerziegler
approved these changes
Nov 22, 2019
parkerziegler
left a comment
parkerziegler
left a comment
There was a problem hiding this comment.
Looks good to me! One smol comment about supporting other keys to send SIGINT which we can take or leave.
Member
Author
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_modulesdirectory from wherevernodejs-dashboardis installed toNODE_PATHso that the portion of the instructions<SNIPPED> -- node -r nodejs-dashboard <SNIPPED>works. Appreciate review from @AaronRobinson and @carbonrobot ! Fixes Error: Cannot find module 'nodejs-dashboard' #90