Docs: Update README for React 18 ReactDOM.createRoot API #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gksander
approved these changes
Jul 14, 2022
Contributor
gksander
left a comment
gksander
left a comment
There was a problem hiding this comment.
LGTM. What do you think about moving the <Highlight .../> markup into a constant so that we can dedup the example code, and just have
render(Content, document.getElementById('root'));
// const root = createRoot(document.getElementById('root'));
// root.render(Content);I'm not married to that, but figured I'd offer it up.
Contributor
Author
|
@gksander Yeah that sounds good to me! I was thinking about doing that anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157