Fix/types #165
Merged
Fix/types #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narinluangrath
commented
Aug 19, 2022
| @@ -1,5 +1,6 @@ | |||
| declare module "prism-react-renderer" { | |||
| import * as React from "react"; | |||
| import type PrismJS from 'prismjs'; | |||
Contributor
Author
There was a problem hiding this comment.
Is there additional work needed to ensure this type definition gets included in the npm package?
Contributor
There was a problem hiding this comment.
no additional work needed -- index.d.ts is already included in the tar
jpdriver
approved these changes
Aug 19, 2022
Contributor
jpdriver
left a comment
jpdriver
left a comment
There was a problem hiding this comment.
LGTM nice catch @narinluangrath thanks
| @@ -1,5 +1,6 @@ | |||
| declare module "prism-react-renderer" { | |||
| import * as React from "react"; | |||
| import type PrismJS from 'prismjs'; | |||
Contributor
There was a problem hiding this comment.
no additional work needed -- index.d.ts is already included in the tar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes to our type definitions and a no-op code change
Prism.tokenizeonly takes two arguments not threePrismJSmodule (closes TypeScript: PrismJS from npm is not assignable to Prism prop #136)