New Prism Language file generation script for v2 #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloskelly13
changed the title
gksander
approved these changes
Apr 15, 2023
Contributor
gksander
left a comment
gksander
left a comment
There was a problem hiding this comment.
Sick! Couple nits to take or leave, but looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates to a TypeScript-based node script that generates language files and automatically includes dependencies. Additionally uglifies the output for a reduced savings
55KBvs141KB.The script also shows the order of exactly what dependencies and languages are included which will help us debug down the road if we have an order-of-operations issue.
This PR is to merge into the
v2branch because I wanted extra eyes on👇🏻 example of the script running