Yield to event loop when synchronous work takes too long #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the current implementation is that like with renderToString we never yield to the event loop. When a large app is rendered a lot of the work happens synchronously. This reimplements the visitor to not be recursive and yield when it's taking longer than 10ms. It does this by putting a YieldFrame onto the suspense queue that preserves the visitor's state and returns to it like with other suspense frames.
kitten
force-pushed
the
event-loop-yielding
branch
from
8d2a284 to
3143304
Compare
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 408 439 +31
Branches 66 72 +6
=====================================
+ Hits 408 439 +31
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new "suspense frame" for yielding to the event loop, called a
YieldFrame.The problem with
react-ssr-prepass' current visiting strategy is that like withreact-dom'srenderToStringwe never yield to the event loop. When a large app is rendered a lot of the work happens synchronously and blocks anything else from happening, even if the user chooses to userenderToNodeStream.This reimplements the visitor to not be recursive and keep its own state. It then yields when visiting elements has been taking longer than
10ms. It does this by putting aYieldFrameonto the suspense queue that preserves the visitor's state and returns to the visitor like with other suspense frames.