5.0.0 #12

tptee · 2016-07-13T23:02:33Z

This should end our API churn.

<Link> now respects modifier keys!
<Link> now accepts either a string or an object like so:

{
  pathname: '/yo/this/is/a/url',
  query: {
    some: 'stuff'
  }
}

<Link> comes in two flavors now: <Link> (old behavior) and <PersistentQueryLink> (persists the previous query string unless the href prop provides one). Since you'll probably just use one or the other, this is a nice pattern:

import { PersistentQueryLink as Link } from 'redux-little-router';

Query string support is fixed across the board!
Added a util that sets up initial state on a server-side render. This correctly sets up query strings on the initial location dispatch.
The history listener now lives in the store enhancer. The middleware no longer lives in the enhancer and must be used separately due to middleware order issues.
The store enhancer's reducer enhancer (enhance!!!) now supports redux-loop.
The current route info now lives at the top of the router state tree like it always should've (no more router.current). You can still access the previous route on router.previous.
New Fragment component that shows or hides children based on active routes (and even conditions of those active routes).
New provideRouter adds the router context to a top-level component. This means that <Link> no longer requires you to pass in dispatch and history (THANK GOD).

alexlande · 2016-07-13T23:09:20Z

src/link.js

+};
+
+const clickedWithModifier = e =>
+  e.button === LEFT_MOUSE_BUTTON &&


I don't think you want to check for LEFT_MOUSE_BUTTON here. (I haven't tested this, so could be wrong).

This behavior should happen if you're clicking a link by pressing enter on the keyboard as well.

We'll also want to check for right clicks and not trigger any behavior on them. This module includes some logic that handles this. Don't know if we want to use the whole thing or not because it does some other stuff too: https://github.com/lukekarrys/local-links/blob/master/local-links.js#L26-L28

Totally right, not sure what I was thinking there 😆

Latest commit should do the trick! Tested with the enter key: uses pushState without modifiers, default if using modifiers 👍 Also checking for the target prop

coveralls · 2016-07-13T23:21:12Z

Coverage decreased (-4.7%) to 91.339% when pulling d7bc687 on feature/better-link into 2fbf246 on master.

coveralls · 2016-07-13T23:23:24Z

Coverage decreased (-4.7%) to 91.339% when pulling d7bc687 on feature/better-link into 2fbf246 on master.

coveralls · 2016-07-13T23:30:07Z

Coverage decreased (-4.7%) to 91.339% when pulling 6189992 on feature/better-link into 2fbf246 on master.

- Use the history query enhancer for query strings - router.current now lives on router - much better link - store enhancer no longer owns middleware

coveralls · 2016-07-13T23:53:06Z

Coverage decreased (-4.7%) to 91.339% when pulling 970e68d on feature/better-link into 2fbf246 on master.

… keys

divmain · 2016-07-14T00:04:04Z

src/initial-state-for-ssr.js

+import createMatcher from './create-matcher';
+
+export default ({ url, query, routes, history }) =>
+  Object.assign({},


No versions of IE support Object.assign, and it doesn't appear to be included in es5-shim either. So we'll either need to call it out that you need an assign polyfill, don't support IE (not really an option for us), or pull in _.assign. I vote for the last option.

Ew! Definitely the lodash one.

coveralls · 2016-07-14T00:06:18Z

Coverage decreased (-6.2%) to 89.844% when pulling ecf2877 on feature/better-link into 2fbf246 on master.

divmain · 2016-07-14T00:06:54Z

A couple of questions, but the rest LGTM! No need for re-review once those are addressed.

coveralls · 2016-07-14T00:09:50Z

Coverage decreased (-6.2%) to 89.844% when pulling ecf2877 on feature/better-link into 2fbf246 on master.

coveralls · 2016-07-14T00:14:27Z

Coverage decreased (-6.1%) to 89.922% when pulling 02c1826 on feature/better-link into 2fbf246 on master.

coveralls · 2016-07-14T00:15:49Z

Coverage decreased (-6.1%) to 89.922% when pulling 02c1826 on feature/better-link into 2fbf246 on master.

divmain · 2016-07-14T00:32:48Z

test/spec/link.spec.jsx

+                .that.contains('/home/messages/a-team');
+              expect(payload).to.have.property('query')
+                .that.deep.equals({ test: 'ing' });
+              done();


If the expect statements above fail, the test will timeout. This is because an Error is thrown, but it is thrown outside the stack frame of the it block (its asynchronous). There are a couple of ways you can resolve this:

Wrap all async expect statements in a try...catch block, and pass any caught errors to done. In other projects, I've done this with a helper function that looks like captureErrors(done, () => { /* expect statements here */ });. This function calls done with a thrown error if it occurs, and otherwise calls done with no args.

Return Promise.resolve().then(() => { /* expect statements here */ }); in the it callback. If the promise rejects, the test will fail with the rejection reason.

Make the test only fake-synchronous. This isn't always possible or desirable, because often library code is asynchronous and outside of your control.

const isNotLeftClick = e => e.button !== LEFT_MOUSE_BUTTON;

e.button is undefined in enzyme simulated clicks. This means that we never reach the real <Link> behavior. Here's the fix:

const isNotLeftClick = e => e.button && e.button !== LEFT_MOUSE_BUTTON;

😆

(the expects should still be wrapped, but that can be done in a separate PR)

…me simulated clicks)

alexlande reviewed Jul 13, 2016
View reviewed changes

tptee added 2 commits July 13, 2016 16:46

- Add Fragment component

862ec14

- Use the history query enhancer for query strings - router.current now lives on router - much better link - store enhancer no longer owns middleware

Fix CI issues

970e68d

tptee force-pushed the feature/better-link branch from 6189992 to 970e68d Compare July 13, 2016 23:50

Link: only prevent default if left-click/enter-press without modifier…

9574721

… keys

divmain reviewed Jul 14, 2016
View reviewed changes

Also check for target in Link

ecf2877

tptee added 2 commits July 13, 2016 17:10

Use lodash assign for compat

b362041

Mention ES5 requirement in README

02c1826

divmain reviewed Jul 14, 2016
View reviewed changes

Fix tests by checking that e.button is truthy (it's undefined on Enzy…

6c36a04

…me simulated clicks)

tptee merged commit b888883 into master Jul 14, 2016

tptee deleted the feature/better-link branch July 14, 2016 17:10

5.0.0 #12

5.0.0 #12

Uh oh!

Conversation

tptee commented Jul 13, 2016

Uh oh!

alexlande Jul 13, 2016

Choose a reason for hiding this comment

Uh oh!

tptee Jul 13, 2016

Choose a reason for hiding this comment

Uh oh!

tptee Jul 14, 2016

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jul 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

divmain Jul 14, 2016

Choose a reason for hiding this comment

Uh oh!

tptee Jul 14, 2016

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jul 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

divmain commented Jul 14, 2016

Uh oh!

coveralls commented Jul 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 14, 2016

Uh oh!

coveralls commented Jul 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

divmain Jul 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tptee Jul 14, 2016

Choose a reason for hiding this comment

Uh oh!

divmain Jul 14, 2016

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Jul 13, 2016 •

edited

Loading

coveralls commented Jul 13, 2016 •

edited

Loading

coveralls commented Jul 13, 2016 •

edited

Loading

coveralls commented Jul 13, 2016 •

edited

Loading

coveralls commented Jul 14, 2016 •

edited

Loading

coveralls commented Jul 14, 2016 •

edited

Loading

coveralls commented Jul 14, 2016 •

edited

Loading

divmain Jul 14, 2016 •

edited

Loading