7.0.0 #21
7.0.0 #21
Conversation
- Replace Karma with Mocha + nyc + babel-plugin-istanbul - Update travis.yml with new coverage command - Remove the middleware and wrap dispatch in the store enhancer instead - Remove unused code for generating a full URL - Rewrite the test suite to actually use stubs/spies
… routes into fixture
|
Any plans for functional tests for the supported browser matrix now that we're completely simulating unit tests w jsdom? Also, what's the word on the street of jsdom vs cheerio? Last I heard everyone was moving to cheerio. (Though haven't checked up in a while...) |
… (differentiated by forServerRender flag)
|
Yep, functional tests will be on the agenda! I'm also working on an example project that we can reuse for those tests. I'm still fuzzy on the differences between jsdom and cheerio. AFAICT, jsdom provides a headless environment + HTML parser, while cheerio provides an HTML parser plus a jQuery-equivalent API. Enzyme uses cheerio under the hood, so maybe we're OK? |
|
Alrighty, this is ready for review! There's a couple of |
| "rules": { | ||
| "no-unused-expressions": "off" | ||
| } | ||
| } |
There was a problem hiding this comment.
Any reason this is JSON, whereas the base .eslintrc is YAML?
|
LGTM! |
|
this PR LGTM but it could use some docs. |
|
Ask and ye shall receive! #22 |
Infrastructure
<Fragment>Patch
<Fragment>ignored route precedence and would mistake concrete routes for parameters (e.g.<Fragment forRoute='/home' />would display for routes like/:wantsparams)Breaking changes
initialStateForSSRtoinitialRouterStateand make it privatepathnameand/or aqueryobject.basenameoption in the enhancer foruseBasename. Accept aforServerRenderflag to determine which history instance to use (memory or browser).