This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Remove all lodash methods and remove array spread #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What's the reasoning behind removing lodash methods? |
Contributor
Author
|
It added about 10k to the bundle (_baseiteratee being the culprit) :( |
Contributor
|
Wow! Alright, I guess that's as good a reason as any. Anyway, LGTM. |
Contributor
Member
Member
|
but, as a side note if you're pulling in lodash bespoke packages for one-each uses, it is probably the right choice to completely remove them... |
Contributor
Author
|
Yeah, it was just single-function packages for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently array spread requires the
Symbolpolyfill:https://babeljs.io/docs/usage/caveats/
We don't want that!