This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Add Flow annotations! #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 526b394 on feature/flow-annotations into * on master*. |
| @@ -0,0 +1,20 @@ | |||
| [ignore] | |||
Contributor
There was a problem hiding this comment.
Do you have to specify all these ignores if you're only including src?
Contributor
Author
There was a problem hiding this comment.
Unfortunately, yeah :/ This is how Flow knows which code is yours and which code is library stuff.
Contributor
|
👏 Nice work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type annotations to all source files of the library. It also includes interface declarations for
history.Flow found a pretty crazy instance of using
for...inon an array instead of an object. Fixed that in the process!/cc @divmain @baer @kenwheeler