Skip to content

Add RN support #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
May 5, 2020
Merged

Add RN support #173

merged 39 commits into from
May 5, 2020

Conversation

@andyrichardson
Copy link
Collaborator

@andyrichardson andyrichardson commented Apr 28, 2020 •
edited
Loading

About

This will allow us to support React Native!

A few quick notes of what has changed:

  • Messaging from devtools to the exchange has been abstracted out
  • The panel can no longer call chrome-specific APIs such as chrome.inspectedWindow.eval (we now use messaging to get the running exchange version)
  • For react native, devtools runs in electron and communicates to the exchange using the websocket protocol

Fix #101

Todo

  • Add bin command
  • Add npm publish script
  • Move all build dependencies (including for the panel) to dev dependencies
  • Update contributing docs

andyrichardson
andyrichardson commented Apr 28, 2020
View reviewed changes
@andyrichardson andyrichardson merged commit 170359c into master May 5, 2020
@andyrichardson andyrichardson deleted the add-electron-app branch May 6, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wgolledge wgolledge Awaiting requested review from wgolledge

@sofiapoh sofiapoh Awaiting requested review from sofiapoh

@JoviDeCroock JoviDeCroock Awaiting requested review from JoviDeCroock

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add React Native support

2 participants

@andyrichardson