Skip to content

Do not use tooltip in Moodle App #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Do not use tooltip in Moodle App #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db/mobile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
'method' => 'mobile_get_formulas',
'styles' => [
'url' => '/question/type/formulas/mobile/styles_app.css',
'version' => '1.00',
'version' => '2.0',
],
],
],
Expand Down
4 changes: 4 additions & 0 deletions mobile/mobile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ var result = {
componentInit: function() {
var div = document.createElement('div');
div.innerHTML = this.question.html;

// We use Bootstrap tooltips in the classic renderer, but we don't want them in the
// Moodle App, because they can take away the focus.
div.innerHTML = div.innerHTML.replaceAll(/data(-bs)?-toggle="tooltip"/g, '');
this.question.text = div.querySelector('.qtext').innerHTML;

// Replace Moodle's correct/incorrect and feedback classes with our own.
Expand Down
111 changes: 9 additions & 102 deletions mobile/styles_app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,88 +1,53 @@
.que.formulas .formulas_input_warning_outer {

display: inline;
position: absolute;
z-index: 1;
}

.que.formulas .formulas_input_warning {
background: transparent;
left: -1.3em;
position: absolute;
top: 0.3em;
}

.que.formulas .formulas_input_info_outer {
display: inline;
position: absolute;
z-index: 2;
}

.que.formulas .formulas_input_info {
background-color: #eef;
border: 1px solid #88c;
left: 0;
position: absolute;
top: 1.63em;
width: 150px;
}

.que.formulas .formulas_input_info_title {
padding: 2px;
}

.que.formulas .formulas_input_info_interpretation {
border-top: 1px solid #88c;
padding: 2px;
}

.que.formulas .formulas_input_info_interpretation_incorrect {
border-top: 1px solid #88c;
color: #bbb;
padding: 2px;
}

.que.formulas .formulas_unit {
display: inline-block;
margin: 0 0 0 0;
width: 40px;
}

.que.formulas .formulas_number {
display: inline-block;
margin: 0 0 0 0;
width: 40px;
}

.que.formulas .formulas_number_unit {
display: inline-block;
margin: 0 0 0 0;
width: 80px;
}

.que.formulas .formulas_numeric {
display: inline-block;
margin: 0 0 0 0;
width: 100px;
}

.que.formulas .formulas_numeric_unit {
display: inline-block;
margin: 0 0 0 0;
width: 200px;
}

.que.formulas .formulas_numerical_formula {
display: inline-block;
margin: 0 0 0 0;
width: 200px;
}

.que.formulas .formulas_numerical_formula_unit {
display: inline-block;
margin: 0 0 0 0;
width: 300px;
}

.que.formulas .formulas_algebraic_formula {
display: inline-block;
margin: 0 0 0 0;
width: 200px;
}

.que.formulas .formulas_algebraic_formula_unit {
display: inline-block;
margin: 0 0 0 0;
width: 300px;
}
Expand All @@ -105,7 +70,6 @@
text-indent: -25px;
}


.que.formulas .formulas_mark {
display: inline;
}
Expand All @@ -132,60 +96,3 @@
.que.formulas .formulation .formulaspartfeedback .incorrect {
background: transparent;
}

/* Styles for the editing form. */
body#page-question-type-formulas .formulas_correctness_show {
display: inline;
}

body#page-question-type-formulas .formulas_input_warning_outer {

display: inline;
position: absolute;
z-index: 1;
}

body#page-question-type-formulas .formulas_input_warning {
background: transparent;
left: -1.3em;
position: absolute;
top: 0.3em;
}

body#page-question-type-formulas .formulas_input_info_outer {
display: inline;
position: absolute;
z-index: 2;
}

body#page-question-type-formulas .formulas_input_info {
background-color: #eef;
border: 1px solid #88c;
left: 0;
position: absolute;
top: 1.94em;
width: 150px;
}
*/
body#page-question-type-formulas .formulas_input_info_title {
padding: 2px;
}

body#page-question-type-formulas .formulas_input_info_interpretation {
border-top: 1px solid #88c;
padding: 2px;
}

body#page-question-type-formulas .formulas_input_info_interpretation_incorrect {
border-top: 1px solid #88c;
color: #bbb;
padding: 2px;
}

/* RTL hacks */
#page-question-type-formulas #id_varsrandom,
#page-question-type-formulas #id_varsglobal {
height: 80px;
direction: ltr;
text-align: left;
}
Loading