Skip to content

Commit c845178

Browse files
fix: use underscore prefix for intentionally unused parameters
- Rename request -> _request in health_check and ready_check (ARG001) - Rename field -> _field in StringRelatedField, HyperlinkedRelatedField, SlugRelatedField converters (ARG002) - Remove spurious pk=None from map_feature_schemas (detail=False action) Co-authored-by: Lauri Gates <laurigates@users.noreply.github.com>
1 parent 7b0ced3 commit c845178

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

django_server/drf_jsonschema/converters.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,23 +262,23 @@ def convert(self, field):
262262
class StringRelatedFieldConverter:
263263
field_class = serializers.StringRelatedField
264264

265-
def convert(self, field):
265+
def convert(self, _field):
266266
return {"type": "string"}
267267

268268

269269
@converter
270270
class HyperlinkedRelatedFieldConverter:
271271
field_class = serializers.HyperlinkedRelatedField
272272

273-
def convert(self, field):
273+
def convert(self, _field):
274274
return {"type": "string", "format": "uri"}
275275

276276

277277
@converter
278278
class SlugRelatedFieldConverter:
279279
field_class = serializers.SlugRelatedField
280280

281-
def convert(self, field):
281+
def convert(self, _field):
282282
# FIXME: hardcoded slug regex
283283
return {"type": "string", "pattern": "^[-a-zA-Z0-9_]+$"}
284284

django_server/olmap/health.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
logger = logging.getLogger(__name__)
99

1010

11-
def health_check(request):
11+
def health_check(_request):
1212
"""Basic health check endpoint for Kubernetes liveness probe"""
1313
return JsonResponse({"status": "healthy", "service": "olmap-backend"})
1414

1515

16-
def ready_check(request):
16+
def ready_check(_request):
1717
"""Readiness check endpoint for Kubernetes readiness probe"""
1818
checks = {}
1919
all_healthy = True

django_server/olmap/rest/views/osm_image_note.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def downvote(self, request, *args, **kwargs):
147147
return Response(serializer.data)
148148

149149
@action(detail=False, methods=["get"])
150-
def map_feature_schemas(self, request, pk=None):
150+
def map_feature_schemas(self, request):
151151
serializer = self.get_serializer()
152152
schemas = {}
153153
for prop_type in models.map_feature_types:

0 commit comments

Comments
 (0)