Skip to content

Commit 69f0937

Browse files
authored
build: move app version to gradle.properties (#485)
1 parent 49443fa commit 69f0937

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

app/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ android {
2626
compileSdk = project.libs.versions.app.build.compileSDKVersion.get().toInt()
2727

2828
defaultConfig {
29-
applicationId = libs.versions.app.version.appId.get()
29+
applicationId = project.property("APP_ID").toString()
3030
minSdk = project.libs.versions.app.build.minimumSDK.get().toInt()
3131
targetSdk = project.libs.versions.app.build.targetSDK.get().toInt()
32-
versionName = project.libs.versions.app.version.versionName.get()
33-
versionCode = project.libs.versions.app.version.versionCode.get().toInt()
32+
versionName = project.property("VERSION_NAME").toString()
33+
versionCode = project.property("VERSION_CODE").toString().toInt()
3434
setProperty("archivesBaseName", "gallery-$versionCode")
3535
}
3636

@@ -101,7 +101,7 @@ android {
101101
kotlinOptions.jvmTarget = project.libs.versions.app.build.kotlinJVMTarget.get()
102102
}
103103

104-
namespace = libs.versions.app.version.appId.get()
104+
namespace = project.property("APP_ID").toString()
105105

106106
lint {
107107
checkReleaseBuilds = false

gradle.properties

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,8 @@ android.enableJetifier=true
22
android.nonTransitiveRClass=true
33
android.useAndroidX=true
44
org.gradle.jvmargs=-Xmx8192m
5+
6+
# Versioning
7+
VERSION_NAME=1.2.1
8+
VERSION_CODE=9
9+
APP_ID=org.fossify.gallery

gradle/libs.versions.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@ app-build-targetSDK = "34"
3939
app-build-minimumSDK = "26"
4040
app-build-javaVersion = "VERSION_17"
4141
app-build-kotlinJVMTarget = "17"
42-
#versioning
43-
app-version-appId = "org.fossify.gallery"
44-
app-version-versionCode = "9"
45-
app-version-versionName = "1.2.1"
4642
[libraries]
4743
#AndroidX
4844
androidx-media3-exoplayer = { module = "androidx.media3:media3-exoplayer", version.ref = "media3Exoplayer" }

0 commit comments

Comments
 (0)