Skip to content

Commit c9dc346

Browse files
authored
build: move app version to gradle.properties (#137)
1 parent fa9ebb0 commit c9dc346

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

app/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ android {
2727
compileSdk = project.libs.versions.app.build.compileSDKVersion.get().toInt()
2828

2929
defaultConfig {
30-
applicationId = libs.versions.app.version.appId.get()
30+
applicationId = project.property("APP_ID").toString()
3131
minSdk = project.libs.versions.app.build.minimumSDK.get().toInt()
3232
targetSdk = project.libs.versions.app.build.targetSDK.get().toInt()
33-
versionName = project.libs.versions.app.version.versionName.get()
34-
versionCode = project.libs.versions.app.version.versionCode.get().toInt()
33+
versionName = project.property("VERSION_NAME").toString()
34+
versionCode = project.property("VERSION_CODE").toString().toInt()
3535
setProperty("archivesBaseName", "notes-$versionCode")
3636
ksp {
3737
arg("room.schemaLocation", "$projectDir/schemas")
@@ -104,7 +104,7 @@ android {
104104
kotlinOptions.jvmTarget = project.libs.versions.app.build.kotlinJVMTarget.get()
105105
}
106106

107-
namespace = libs.versions.app.version.appId.get()
107+
namespace = project.property("APP_ID").toString()
108108

109109
lint {
110110
checkReleaseBuilds = false

gradle.properties

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,8 @@ android.enableJetifier=true
22
android.useAndroidX=true
33
android.nonTransitiveRClass=true
44
org.gradle.jvmargs=-Xmx8g
5+
6+
# Versioning
7+
VERSION_NAME=1.2.0
8+
VERSION_CODE=5
9+
APP_ID=org.fossify.notes

gradle/libs.versions.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ app-build-targetSDK = "34"
2121
app-build-minimumSDK = "26"
2222
app-build-javaVersion = "VERSION_17"
2323
app-build-kotlinJVMTarget = "17"
24-
#versioning
25-
app-version-appId = "org.fossify.notes"
26-
app-version-versionCode = "5"
27-
app-version-versionName = "1.2.0"
2824
[libraries]
2925
#AndroidX
3026
androidx-constraintlayout = { module = "androidx.constraintlayout:constraintlayout", version.ref = "androidx-constraintlayout" }

0 commit comments

Comments
 (0)