Skip to content

More logs #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2019
Merged

More logs #149

merged 2 commits into from
Apr 9, 2019

Conversation

@apkar
Copy link
Contributor

@apkar apkar commented Apr 9, 2019 •
edited
Loading

  • TraceEvent().error(e) gives better error context
  • Removed some commented code
  • Minor conditional statement cleanup

@apkar
Better error messages.
9d4cbab 
* TraceEvent().error(e) gives better error context
* Removed some commented code.
@apkar apkar requested a review from dongxinEric April 9, 2019 22:09
dongxinEric
dongxinEric approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@dongxinEric dongxinEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apkar apkar merged commit 1214a6f into FoundationDB:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dongxinEric dongxinEric dongxinEric approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apkar @dongxinEric