Skip to content

Resolves #49: Log the slow query based on how long the query takes to run. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2019
Merged

Resolves #49: Log the slow query based on how long the query takes to run. #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63cf5ae
Log the slow query based on how long the query takes to run.
Apr 21, 2019
07f49aa
Rename and use correct time unit
Apr 21, 2019
34093ae
Move the constant into knobs
Apr 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/ExtMsg.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,15 @@ ACTOR static Future<Void> doRun(Reference<ExtMsgQuery> query, Reference<ExtConne
}
}

DocumentLayer::metricReporter->captureTime(DocLayerConstants::MT_TIME_QUERY_LATENCY_US,
(timer_int() - startTime) / 1000);
uint64_t queryLatencyMicroSeconds = (timer_int() - startTime) / 1000;
DocumentLayer::metricReporter->captureTime(DocLayerConstants::MT_TIME_QUERY_LATENCY_US, queryLatencyMicroSeconds);

if (slowQueryLogging && queryLatencyMicroSeconds >= DOCLAYER_KNOBS->SLOW_QUERY_THRESHOLD_MICRO_SECONDS) {
TraceEvent(SevWarn, "SlowQuery")
.detail("ThresholdMicroSeconds", DOCLAYER_KNOBS->SLOW_QUERY_THRESHOLD_MICRO_SECONDS)
.detail("DurationMicroSeconds", queryLatencyMicroSeconds)
.detail("Query", query->toString());
}

return Void();
}
Expand Down
1 change: 1 addition & 0 deletions src/Knobs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ DocLayerKnobs::DocLayerKnobs(bool enable) {
init(MAX_RETURNABLE_DATA_SIZE, (1 << 20) * 16);
init(CURSOR_EXPIRY, 60 * 10); /* seconds */
init(DEFAULT_RETURNABLE_DATA_SIZE, (1 << 20) * 4);
init(SLOW_QUERY_THRESHOLD_MICRO_SECONDS, 10 * 1000 * 1000);
}

bson::BSONObj DocLayerKnobs::dumpKnobs() const {
Expand Down
1 change: 1 addition & 0 deletions src/Knobs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class DocLayerKnobs : public Knobs {
int MAX_RETURNABLE_DATA_SIZE;
int CURSOR_EXPIRY;
int DEFAULT_RETURNABLE_DATA_SIZE;
int SLOW_QUERY_THRESHOLD_MICRO_SECONDS;

explicit DocLayerKnobs(bool randomize = false);

Expand Down