Skip to content

Resolves issue #94: Add renameCollection command #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apkar merged 4 commits into from
Aug 1, 2019
Merged

Resolves issue #94: Add renameCollection command #199

apkar merged 4 commits into from
Aug 1, 2019

Conversation

@drkannan
Copy link
Contributor

@drkannan drkannan commented Jul 19, 2019

This PR resolves an issue #94

Registered new command for Rename

Validated the collection name for existence

Used MOVE function to create and update the directory path

@fdb-build
Copy link

fdb-build commented Jul 19, 2019

Can one of the admins verify this patch?

3 similar comments
@fdb-build
Copy link

fdb-build commented Jul 19, 2019

Can one of the admins verify this patch?

@fdb-build
Copy link

fdb-build commented Jul 19, 2019

Can one of the admins verify this patch?

@fdb-build
Copy link

fdb-build commented Jul 19, 2019

Can one of the admins verify this patch?

@apkar apkar self-requested a review July 19, 2019 03:30
@apkar
Copy link
Contributor

apkar commented Jul 19, 2019 •
edited
Loading

@fdb-build test this please

@apkar
Copy link
Contributor

apkar commented Jul 19, 2019

@drkannan Please fix the format. You can simply run make format to fix the format.

@apkar apkar self-assigned this Jul 19, 2019
@drkannan
Copy link
Contributor Author

drkannan commented Jul 19, 2019

@apkar Ok, will look at it, Thanks.

@apkar
Copy link
Contributor

apkar commented Jul 19, 2019

@fdb-build test this please

dongxinEric
dongxinEric reviewed Jul 19, 2019
View reviewed changes
dongxinEric
dongxinEric reviewed Jul 19, 2019
View reviewed changes
apkar
apkar suggested changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@apkar apkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have suggested couple of changes. Can you add couple of smoke tests please? You can follow the example here. Our tests are based on PyTest framework.

@senthil-db-expert
Copy link

senthil-db-expert commented Jul 20, 2019

@apkar Sure, will work on the suggested changes and add smoke tests.

@senthil-db-expert
Copy link

senthil-db-expert commented Jul 31, 2019

@apkar Could you please review the changes made.

@apkar
Copy link
Contributor

apkar commented Jul 31, 2019

@fdb-build test this please

apkar
apkar approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@apkar apkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apkar apkar merged commit ee611d8 into FoundationDB:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dongxinEric dongxinEric dongxinEric left review comments

@apkar apkar apkar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@apkar apkar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@drkannan @fdb-build @apkar @senthil-db-expert @dongxinEric @sakthivel-axim