Add documentation for KeySpace structure #3687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottDugas
requested changes
Oct 22, 2025
...src/main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/package-info.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/package-info.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/package-info.java
Outdated
Show resolved
Hide resolved
ScottDugas
reviewed
Oct 23, 2025
| * but then the key tuple {@code ["permissions", 8]} is ambiguous and cannot be determined whether it refers to userId 8 or groupId 8. | ||
| * This can cause data corruption where data meant to be written to one area of the model overwrites other pieces of data from | ||
| * another part of the model. | ||
| * The {@link com.apple.foundationdb.record.provider.foundationdb.keyspace.KeySpace} will prevent this from happening. a properly |
There was a problem hiding this comment.
Suggested change
| * The {@link com.apple.foundationdb.record.provider.foundationdb.keyspace.KeySpace} will prevent this from happening. a properly | |
| * The {@link com.apple.foundationdb.record.provider.foundationdb.keyspace.KeySpace} will prevent this from happening. A properly |
…ord/provider/foundationdb/keyspace/package-info.java Co-authored-by: Scott Dugas <scott.dugas@gmail.com>
ScottDugas
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.