Add vector type support for Direct Access API inserts #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables inserting vector data types through the relational Direct Access API with full validation: - Type checking ensures vectors match column precision (FLOAT/16, HALF/32, DOUBLE/64) - Dimension validation verifies vector size matches schema definition - Null/empty vector handling for optional vector columns - Comprehensive test coverage via InsertVectorTest for all insert scenarios Also refactors vector parsing logic into VectorUtils.parseVector() to eliminate code duplication across MessageTuple and FRL.
- before current version, (particularly, version 4.8.11.0) we allow inserting vectors of incompatible precision and dimensions. - fix the tests to reflect that.
- fix a problem with JDBC handling of `null` vector value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables inserting vector data types through the relational Direct Access API with full validation:
Also refactors vector parsing logic into VectorUtils.parseVector() to eliminate code duplication across MessageTuple and FRL.