Skip to content

Add ResultSet MetaData tests to assert current behavior with underlying struct type names #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

Add ResultSet MetaData tests to assert current behavior with underlying struct type names #3744

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75c580a
Add ResultSet MetaData tests to assert current behavior with underlyi…
arnaud-lacurie Nov 12, 2025
ae40589
Add additional test
arnaud-lacurie Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ...e/src/test/java/com/apple/foundationdb/relational/recordlayer/StructDataMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,37 @@ void canReadSingleStruct() throws Exception {
}
}

@Test
void canReadProjectedStructTypeNameInNestedStar() throws Exception {
try (final RelationalResultSet resultSet = statement.executeQuery("SELECT (*) FROM T")) {
Assertions.assertTrue(resultSet.next(), "Did not find a record!");
RelationalStruct struct = resultSet.getStruct(1).getStruct("ST1");
Assertions.assertEquals("STRUCT_1", struct.getMetaData().getTypeName());
}
}

// When projecting *, the underlying struct types are lost and replaced with a generic UUID type.
// This test should be replaced with the correct expected behavior once this is fixed.
// When projecting (*), everything works as expected, see `canReadProjectedStructTypeNameInNestedStar`.
// See https://github.com/FoundationDB/fdb-record-layer/issues/3743
@Test
void cannotReadProjectedStructTypeNameInUnnestedStar() throws Exception {
try (final RelationalResultSet resultSet = statement.executeQuery("SELECT * FROM T")) {
Assertions.assertTrue(resultSet.next(), "Did not find a record!");
RelationalStruct struct = resultSet.getStruct("ST1");
Assertions.assertNotEquals("STRUCT_1", struct.getMetaData().getTypeName());
}
}

@Test
void canReadProjectedStructTypeNameDirectlyProjected() throws Exception {
try (final RelationalResultSet resultSet = statement.executeQuery("SELECT ST1 FROM T")) {
Assertions.assertTrue(resultSet.next(), "Did not find a record!");
RelationalStruct struct = resultSet.getStruct("ST1");
Assertions.assertEquals("STRUCT_1", struct.getMetaData().getTypeName());
}
}

@Test
void errorAccessingNonExistentColumn() throws Exception {
try (final RelationalResultSet resultSet = statement.executeGet("T", new KeySet().setKeyColumn("NAME", "test_record_1"), Options.NONE)) {
Expand Down
Loading