Skip rank index match candidate generation for SQL queries #3748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgrieser
approved these changes
Nov 13, 2025
Collaborator
alecgrieser
left a comment
alecgrieser
left a comment
There was a problem hiding this comment.
LGTM. This pretty clearly will allow us to get around the issue with #3737. We may want to add some more testing/documentation, though we could do that as a follow up
| matchCandidatesBuilder.addAll(matchCandidateRegistry.createMatchCandidates(metaData, index, false)); | ||
| if (IndexTypes.RANK.equals(index.getType())) { | ||
| final IndexExpansionInfo info = IndexExpansionInfo.createInfo(metaData, index, false); | ||
| // For rank() we still want to create the match candidate for BY_VALUE scans. |
Collaborator
There was a problem hiding this comment.
It would probably be good to have a note here about why we are skipping rank index match candidate generation here (namely that it's not quite ready for SQL but that we want to continue to generate it RecordQuery queries).
One of the reasons it's not ready is that it can't handle multiple grouping columns (see #3737), and it would be good to have a test covering that.
alecgrieser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip generating rank index match candidate for SQL, but keep the value index match candidate.