Skip to content

Conversation

@vishesh
Copy link
Contributor

@vishesh vishesh commented Oct 8, 2025

No description provided.

@vishesh vishesh requested a review from jzhou77 October 8, 2025 02:18
@vishesh vishesh merged commit 3686655 into FoundationDB:main Oct 8, 2025
1amageek added a commit to 1amageek/fdb-swift-bindings that referenced this pull request Nov 8, 2025
Move strinc() from FDB.Bytes extension to FDB static method. Since
FDB.Bytes is a typealias for [UInt8], extending it would pollute all
Array<UInt8> types with the strinc() method in the public API.

The new API matches other language bindings more closely:
- Go: fdb.Strinc()
- Python: fdb.strinc()
- Java: ByteArrayUtil.strinc()

Usage: try FDB.strinc(bytes) instead of try bytes.strinc()

Addresses: glbrntt review comment FoundationDB#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants